Hi Mattias, > A more extensive description of the purpose of the eventmode helper > library would be helpful. > > Is this supposed to be a generic framework for real-world > applications, or only something to simplify DPDK the implementation of > DPDK example programs and similar? This is intended as a generic framework, but the initial targets would be limited to DPDK example applications. For any application to use an event device for dynamic load balancing, it has to configure the event device and the adapters. Configuring the adapters would involve providing various parameters based on which the dynamic scheduling should happen. But requiring the application to do all this configuration would make the application complicated as well as the same code has to be repeated for a new application. Event mode helper tries to solve that. All the complex configuration would be implemented by the helper library and the helper library would provide a default conf as well. These patches facilitate event mode configuration in a easy to use manner. My idea is that, for a poll mode DPDK example to operate in event mode, a couple of helper functions and a lean worker thread should suffice. So even complex DPDK examples and real world applications will benefit from this helper library. We plan to propose a change to ipsec-secgw to operate in event mode once this proposal is merged. I'll update the cover-letter to add above details when sending v2.
Thanks, Anoob > -----Original Message----- > From: dev <[email protected]> On Behalf Of Mattias Rönnblom > Sent: Tuesday, June 11, 2019 4:14 PM > To: Jerin Jacob Kollanukkaran <[email protected]>; Anoob Joseph > <[email protected]>; Nikhil Rao <[email protected]>; Erik Gabriel > Carrillo <[email protected]>; Abhinandan Gujjar > <[email protected]>; Bruce Richardson > <[email protected]>; Pablo de Lara > <[email protected]> > Cc: Narayana Prasad Raju Athreya <[email protected]>; [email protected]; > Lukas Bartosik <[email protected]>; Pavan Nikhilesh Bhagavatula > <[email protected]>; Hemant Agrawal > <[email protected]>; Nipun Gupta <[email protected]>; Harry > van Haaren <[email protected]>; Liang Ma > <[email protected]> > Subject: [EXT] Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper > library > > External Email > > ---------------------------------------------------------------------- > On 2019-06-07 11:48, Jerin Jacob Kollanukkaran wrote: > >> -----Original Message----- > >> From: Anoob Joseph <[email protected]> > >> Sent: Monday, June 3, 2019 11:02 PM > >> To: Jerin Jacob Kollanukkaran <[email protected]>; Nikhil Rao > >> <[email protected]>; Erik Gabriel Carrillo > >> <[email protected]>; Abhinandan Gujjar > >> <[email protected]>; Bruce Richardson > >> <[email protected]>; Pablo de Lara > >> <[email protected]> > >> Cc: Anoob Joseph <[email protected]>; Narayana Prasad Raju Athreya > >> <[email protected]>; [email protected]; Lukas Bartosik > >> <[email protected]>; Pavan Nikhilesh Bhagavatula > >> <[email protected]>; Hemant Agrawal > <[email protected]>; > >> Nipun Gupta <[email protected]>; Harry van Haaren > >> <[email protected]>; Mattias Rönnblom > >> <[email protected]>; Liang Ma <[email protected]> > >> Subject: [PATCH 00/39] adding eventmode helper library > >> > >> This series adds support for eventmode helper library and l2fwd-event > >> application. > >> > >> First 13 patches creates a new l2fwd application (l2fwd-event). Minor > >> code reorganization is done to faciliate seamless integration of > eventmode. > >> > >> Next 22 patches adds eventmode helper library. This library abstracts > >> the configuration of event device & Rx-Tx event adapters. The library > >> can be extended to allow users to control all the configuration > >> exposed by adapters and eth device. > >> > >> Last 4 patches implements eventmode in l2fwd-event application. With > >> event device and adapters, fine tuned threads (based on dev > >> capabilities) can be drafted to maximize performance. Eventmode > >> library facilitates this and l2fwd-event demonstrates this usage. > >> > >> With the introduction of eventmode helper library, any poll mode > >> application can be converted to an eventmode application with simple > >> steps, enabling multi-core scaling and dynamic load balancing to > >> various example applications. > > > > > > Anyone planning to review this changes? > > I will spend time to review this. Requesting the review from other > eventdev stake holders. > > > > A more extensive description of the purpose of the eventmode helper > library would be helpful. > > Is this supposed to be a generic framework for real-world applications, or > only something to simplify DPDK the implementation of DPDK example > programs and similar?
