Hi Jerin, Please see inline.
Thanks, Anoob > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:54 PM > To: Anoob Joseph <[email protected]>; Nikhil Rao > <[email protected]>; Erik Gabriel Carrillo <[email protected]>; > Abhinandan Gujjar <[email protected]>; Bruce Richardson > <[email protected]>; Pablo de Lara > <[email protected]> > Cc: Anoob Joseph <[email protected]>; Narayana Prasad Raju Athreya > <[email protected]>; [email protected]; Lukas Bartosik > <[email protected]>; Pavan Nikhilesh Bhagavatula > <[email protected]>; Hemant Agrawal > <[email protected]>; Nipun Gupta <[email protected]>; Harry > van Haaren <[email protected]>; Mattias Rönnblom > <[email protected]>; Liang Ma <[email protected]> > Subject: RE: [PATCH 19/39] eventdev: add common initialize routine for > eventmode devs > > > -----Original Message----- > > From: Anoob Joseph <[email protected]> > > Sent: Monday, June 3, 2019 11:02 PM > > To: Jerin Jacob Kollanukkaran <[email protected]>; Nikhil Rao > > <[email protected]>; Erik Gabriel Carrillo > > <[email protected]>; Abhinandan Gujjar > > <[email protected]>; Bruce Richardson > > <[email protected]>; Pablo de Lara > > <[email protected]> > > Cc: Anoob Joseph <[email protected]>; Narayana Prasad Raju Athreya > > <[email protected]>; [email protected]; Lukas Bartosik > > <[email protected]>; Pavan Nikhilesh Bhagavatula > > <[email protected]>; Hemant Agrawal > <[email protected]>; > > Nipun Gupta <[email protected]>; Harry van Haaren > > <[email protected]>; Mattias Rönnblom > > <[email protected]>; Liang Ma <[email protected]> > > Subject: [PATCH 19/39] eventdev: add common initialize routine for > > eventmode devs > > > > Adding framework for common initialization routine for event mode. > > Event mode would involve initialization of multiple devices, like > > eventdev, ethdev etc and this routine would be the placeholder for all > > initialization to come in. > > > > Signed-off-by: Anoob Joseph <[email protected]> > > Signed-off-by: Lukasz Bartosik <[email protected]> > > --- > > > > +/* Helper functions for initialization, & launching workers */ > > + > > +/** > > + * Initialize event mode devices > > + * > > + * Application could call this function to get the event device, eth > > +device > > + * and eth rx adapter initialized according to the conf populated > > +using the > > + * command line args. > > + * > > + * Application is expected to initialize the eth device and then the > > +eventmode > > + * helper subsystem will stop & start eth device according to it's > > requirement. > > + * So call to this function should be done after the eth device is > > +successfully > > + * initialized. > > + * > > + * @param mode_conf > > + * Configuration of the mode in which app is doing packet handling > > + * @return > > + * - 0 on success. > > + * - (<0) on failure. > > + */ > > +int32_t __rte_experimental > > +rte_eventmode_helper_initialize_devs( > > + struct rte_eventmode_helper_conf *mode_conf); > > + > > # Prefer to change to rte_event_helper_init() and introduce the counter part [Anoob] This routine is doing init of devs (not the helper library). So are you okay with renaming it to rte_event_helper_devs_init() and rte_event_helper_devs_uninit(), and retain the functionality as before? > for the same(rte_event_helper_uninit() or rte_event_helper_fini()) # > introduce params structure taking another paraments input instead of new > APIs. > # let library return rte_event_helper_conf* object for further operations. [Anoob] Parse args will parse the command line arguments and return the conf. Based on the conf we setup the required devices (eventdev, Rx adapter & Tx adapter, can be expanded to handle ethdev also). > > > > #ifdef __cplusplus > > } > > #endif > > -- > > 2.7.4
