Hi Erik, Please see inline.
Thanks, Anoob > -----Original Message----- > From: dev <[email protected]> On Behalf Of Carrillo, Erik G > Sent: Monday, June 10, 2019 8:26 PM > To: Anoob Joseph <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; Rao, Nikhil <[email protected]>; Gujjar, > Abhinandan S <[email protected]>; Richardson, Bruce > <[email protected]>; De Lara Guarch, Pablo > <[email protected]> > Cc: Narayana Prasad Raju Athreya <[email protected]>; [email protected]; > Lukas Bartosik <[email protected]>; Pavan Nikhilesh Bhagavatula > <[email protected]>; Hemant Agrawal > <[email protected]>; Nipun Gupta <[email protected]>; Van > Haaren, Harry <[email protected]>; Mattias Rönnblom > <[email protected]>; Ma, Liang J <[email protected]> > Subject: [EXT] Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in > eventmode > > External Email > > ---------------------------------------------------------------------- > > -----Original Message----- > > From: Anoob Joseph <[email protected]> > > Sent: Monday, June 3, 2019 12:32 PM > > To: Jerin Jacob <[email protected]>; Rao, Nikhil > > <[email protected]>; Carrillo, Erik G <[email protected]>; > > Gujjar, Abhinandan S <[email protected]>; Richardson, Bruce > > <[email protected]>; De Lara Guarch, Pablo > > <[email protected]> > > Cc: Anoob Joseph <[email protected]>; Narayana Prasad > > <[email protected]>; [email protected]; Lukasz Bartosik > > <[email protected]>; Pavan Nikhilesh <[email protected]>; > > Hemant Agrawal <[email protected]>; Nipun Gupta > > <[email protected]>; Van Haaren, Harry > <[email protected]>; > > Mattias Rönnblom <[email protected]>; Ma, Liang J > > <[email protected]> > > Subject: [PATCH 24/39] eventdev: add Rx adapter init in eventmode > > > > Adding rx adapter conf. The helper init routine would be initializing > > the rx adapter according to the conf. > > > > Signed-off-by: Anoob Joseph <[email protected]> > > Signed-off-by: Lukasz Bartosik <[email protected]> > > --- > > <...Snipped...> > > > diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h > > b/lib/librte_eventdev/rte_eventmode_helper_internal.h > > index 2a6cd90..9c68605 100644 > > --- a/lib/librte_eventdev/rte_eventmode_helper_internal.h > > +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h > > @@ -35,6 +35,12 @@ > > /* Max event devices supported */ > > #define EVENT_MODE_MAX_EVENT_DEVS RTE_EVENT_MAX_DEVS > > > > +/* Max Rx adapters supported */ > > +#define EVENT_MODE_MAX_RX_ADAPTERS RTE_EVENT_MAX_DEVS > > + > > +/* Max Rx adapter connections */ > > +#define EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER 16 > > + > > /* Max event queues supported per event device */ #define > > EVENT_MODE_MAX_EVENT_QUEUES_PER_DEV > > RTE_EVENT_MAX_QUEUES_PER_DEV > > > > @@ -50,12 +56,33 @@ struct eventdev_params { > > uint8_t ev_queue_mode; > > }; > > > > Should the struct below be named "rx_adapter_connection_info" since you > add "tx_adapter_connection_info" in a later patch? [Anoob] Yes. Will make this change in v2. > > > +/* Rx adapter connection info */ > > +struct adapter_connection_info { > > + uint8_t ethdev_id; > > + uint8_t eventq_id; > > + int32_t ethdev_rx_qid; > > +}; > > + > > +/* Rx adapter conf */ > > +struct rx_adapter_conf { > > + int32_t eventdev_id; > > + int32_t adapter_id; > > + uint32_t rx_core_id; > > + uint8_t nb_connections; > > + struct adapter_connection_info > > + > > conn[EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER]; > > +}; > > + > > <...Snipped...> > > Regards, > Erik
