On 6/18/2019 2:49 PM, Reshma Pattan wrote: > telemetry has support for fetching port based stats > from metrics library. > > Metrics library also has global stats which are > not fetched by telemetry, so extend telemetry to > fetch the global metrics. > > Signed-off-by: Reshma Pattan <reshma.pat...@intel.com> > Acked-by: Kevin Laatz <kevin.la...@intel.com>
Hi Reshma, Kevin, Not related to this patch, but when telemetry library enabled, it is causing some warnings [1] with gcc9 The [-Waddress-of-packed-member] warnings already disable for gcc, but you need following update to "lib/librte_telemetry/Makefile": -CFLAGS += -I$(SRCDIR) +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) Can you please take care of this? [1] In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev.h:160, from .../dpdk/lib/librte_telemetry/rte_telemetry_parser.c:13: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h: In function ‘rte_is_broadcast_ether_addr’: .../dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h:152:2: warning: converting a packed ‘const struct rte_ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’ {aka ‘const short unsigned int’} pointer (alignment 2) may result in an unaligned pointer value [-Waddress-of-packed-member] 152 | const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea; | ^~~~~