Re: [dpdk-dev] [PATCH v3 07/14] net/ppfe: add device start stop operations

[Gagandeep Singh]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@intel.com>
> Sent: Friday, October 4, 2019 9:13 PM
> To: Gagandeep Singh <g.si...@nxp.com>; dev@dpdk.org
> Cc: tho...@monjalon.net; Akhil Goyal <akhil.go...@nxp.com>
> Subject: Re: [PATCH v3 07/14] net/ppfe: add device start stop operations
> 
> On 10/1/2019 12:02 PM, Gagandeep Singh wrote:
> > This patch adds device start, stop and close
> > operations.
> >
> > Signed-off-by: Gagandeep Singh <g.si...@nxp.com>
> > Signed-off-by: Akhil Goyal <akhil.go...@nxp.com>
> > Acked-by: Nipun Gupta <nipun.gu...@nxp.com>
> 
> <...>
> 
> > +static int
> > +pfe_eth_info(struct rte_eth_dev *dev,
> > +           struct rte_eth_dev_info *dev_info)
> > +{
> > +   struct pfe_eth_priv_s *internals = dev->data->dev_private;
> > +
> > +   dev_info->if_index = internals->id;
> > +   dev_info->max_mac_addrs = PPFE_MAX_MACS;
> > +   dev_info->max_rx_pktlen = JUMBO_FRAME_SIZE;
> > +   dev_info->max_rx_queues = dev->data->nb_rx_queues;
> > +   dev_info->max_tx_queues = dev->data->nb_tx_queues;
> > +   dev_info->min_rx_bufsize = HIF_RX_PKT_MIN_SIZE;
> 
> Since set MTU supported in this patchet, it can be good to set 'min_mtu' &
> 'max_mtu' too.
Ok.