Re: [dpdk-dev] [PATCH v3 13/14] net/ppfe: add link status update

[Gagandeep Singh]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@intel.com>
> Sent: Friday, October 4, 2019 9:13 PM
> To: Gagandeep Singh <g.si...@nxp.com>; dev@dpdk.org
> Cc: tho...@monjalon.net
> Subject: Re: [PATCH v3 13/14] net/ppfe: add link status update
> 
> On 10/1/2019 12:02 PM, Gagandeep Singh wrote:
> > This patch add link related operations like
> > link update, up and down.
> >
> > Signed-off-by: Gagandeep Singh <g.si...@nxp.com>
> > Acked-by: Nipun Gupta <nipun.gu...@nxp.com>
> > Acked-by: Akhil Goyal <akhil.go...@nxp.com>
> 
> <...>
> 
> > +
> > +static int
> > +pfe_eth_link_update(struct rte_eth_dev *dev,
> > +                           int wait_to_complete __rte_unused)
> 
> nitpicking but, this can be single line ...
Sure.