> -----Original Message----- > From: Aaron Conole <[email protected]> > Sent: Tuesday, November 26, 2019 8:56 AM > To: [email protected] > Cc: Van Haaren, Harry <[email protected]>; Richardson, Bruce > <[email protected]>; Pavan Nikhilesh > <[email protected]>; Eads, Gage <[email protected]>; Thomas > Monjalon <[email protected]>; David Marchand > <[email protected]> > Subject: [PATCH] service: don't walk out of bounds when checking services > > The service_valid call is used without properly bounds checking the input > parameter. Almost all instances of the service_valid call are inside a for() > loop that prevents excessive walks, but some of the public APIs don't bounds > check and will pass invalid arguments. > > Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, and > adding a bounds check to one service_valid() use. > > Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") > Fixes: e9139a32f6e8 ("service: add function to run on app lcore") > Fixes: e30dd31847d2 ("service: add mechanism for quiescing") > Signed-off-by: Aaron Conole <[email protected]>
Acked-by: Gage Eads <[email protected]> Thanks, Gage
