> From: Phil Yang <[email protected]> > Sent: Tuesday, March 17, 2020 1:18 AM > To: [email protected]; Van Haaren, Harry <[email protected]>; > Ananyev, Konstantin <[email protected]>; > [email protected]; [email protected]; [email protected] > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected] > Subject: [PATCH v3 07/12] service: remove rte prefix from static functions > > Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses") > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: [email protected] > > Signed-off-by: Phil Yang <[email protected]> > Reviewed-by: Honnappa Nagarahalli <[email protected]>
This patchset needs a rebase since the EAL file movement got merged, however I'll review here so we can include some Acks etc and make progress. Is this really a "Fix"? The internal function names were not exported in the .map file, so are not part of public ABI. This is an internal naming improvement (thanks for doing cleanup), but I don't think the Fixes: tags make sense? Also I'm not sure if we want to port this patch back to stable? Changing (internal) function names seems like unnecessary churn, and hence risk to a stable release, without any benefit? --- <snip patch diff>
