Hi David,
> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Saturday, April 25, 2020 22:39
> To: Wang, Haiyue <haiyue.w...@intel.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <tho...@monjalon.net>; Richardson,
> Bruce
> <bruce.richard...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; Neil
> Horman
> <nhor...@tuxdriver.com>; Ray Kinsella <m...@ashroe.eu>
> Subject: Re: [PATCH v7 0/6] dpdk: introduce __rte_internal tag
>
> On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang <haiyue.w...@intel.com> wrote:
> >
> > Move the internal function into INTERNAL session to avoid the ABI
> > checking, and it is only used for DPDK drivers or related library.
> >
> > __rte_internal funA
> >
> > INTERNAL {
> > global:
> >
> > funA
> > };
>
> Thanks a lot for working on this.
> I did some modifications (see my replies on patch 3 and 5) and applied
> this series.
>
> We are just missing the update on the scripts mentioned in a previous mail.
> Can you work on this for rc2?
>
Do you mean ?
> > > This will apply to common drivers that will be 100% internal.
> > > Not sure if this is an issue.
> >
> > This part should be fine, I want others to be aware of this.
> I am not one of the ABI maintainers, but in my opinion it is OK
> to have "pure internal" libs with version 0.x.
I've tested it with Intel's drivers/common/iavf, it works as expected.
a). librte_common_iavf.so.0.200.2
b). Skipped experimental library librte_common_iavf.dump.
This has been updated by your modification.
+ if is_stable
lib_version = abi_version
so_version = stable_so_version
+ else
+ lib_version = experimental_abi_version
+ so_version = experimental_so_version
endif
> Thanks again!
>
>
> --
> David Marchand
