> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Wednesday, April 29, 2020 16:22 > To: Wang, Haiyue <[email protected]> > Cc: dev <[email protected]>; Thomas Monjalon <[email protected]>; Richardson, > Bruce > <[email protected]>; Yigit, Ferruh <[email protected]>; Neil > Horman > <[email protected]>; Ray Kinsella <[email protected]> > Subject: Re: [PATCH v7 0/6] dpdk: introduce __rte_internal tag > > On Sat, Apr 25, 2020 at 8:10 PM Wang, Haiyue <[email protected]> wrote: > > > > Hi David, > > > > > -----Original Message----- > > > From: David Marchand <[email protected]> > > > Sent: Saturday, April 25, 2020 22:39 > > > To: Wang, Haiyue <[email protected]> > > > Cc: dev <[email protected]>; Thomas Monjalon <[email protected]>; > > > Richardson, Bruce > > > <[email protected]>; Yigit, Ferruh <[email protected]>; > > > Neil Horman > > > <[email protected]>; Ray Kinsella <[email protected]> > > > Subject: Re: [PATCH v7 0/6] dpdk: introduce __rte_internal tag > > > > > > On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang <[email protected]> wrote: > > > > > > > > Move the internal function into INTERNAL session to avoid the ABI > > > > checking, and it is only used for DPDK drivers or related library. > > > > > > > > __rte_internal funA > > > > > > > > INTERNAL { > > > > global: > > > > > > > > funA > > > > }; > > > > > > Thanks a lot for working on this. > > > I did some modifications (see my replies on patch 3 and 5) and applied > > > this series. > > > > > > We are just missing the update on the scripts mentioned in a previous > > > mail. > > > Can you work on this for rc2? > > > > > > > Do you mean ? > > Sorry, I was referring to another mail: > """ > > We are missing updates on devtools/check-abi-version.sh and > > devtools/update_version_map_abi.py. > """ > > Those scripts devtools/check-abi-version.sh and > devtools/update_version_map_abi.py are not "internal" aware. > Can you take care of them? >
Got it, I will try. > > > > > > This will apply to common drivers that will be 100% internal. > > > > > Not sure if this is an issue. > > > > > > > > This part should be fine, I want others to be aware of this. > > > > > I am not one of the ABI maintainers, but in my opinion it is OK > > > to have "pure internal" libs with version 0.x. > > > > I've tested it with Intel's drivers/common/iavf, it works as expected. > > a). librte_common_iavf.so.0.200.2 > > b). Skipped experimental library librte_common_iavf.dump. > > > > This has been updated by your modification. > > + if is_stable > > lib_version = abi_version > > so_version = stable_so_version > > + else > > + lib_version = experimental_abi_version > > + so_version = experimental_so_version > > endif > > Thanks for testing. > > > -- > David Marchand
