On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: > > >> -----Original Message----- >> From: Nithin Dabilpuram <nithind1...@gmail.com> >> Sent: Wednesday, April 22, 2020 6:21 PM >> To: Singh, Jasvinder <jasvinder.si...@intel.com>; Dumitrescu, Cristian >> <cristian.dumitre...@intel.com>; Thomas Monjalon >> <tho...@monjalon.net>; Yigit, Ferruh <ferruh.yi...@intel.com>; Andrew >> Rybchenko <arybche...@solarflare.com> >> Cc: dev@dpdk.org; jer...@marvell.com; kka...@marvell.com; Nithin >> Dabilpuram <ndabilpu...@marvell.com> >> Subject: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt >> mode >> >> From: Nithin Dabilpuram <ndabilpu...@marvell.com> >> >> Some NIC hardware support shaper to work in packet mode i.e >> shaping or ratelimiting traffic is in packets per second (PPS) as >> opposed to default bytes per second (BPS). Hence this patch >> adds support to configure shared or private shaper in packet mode, >> provide rate in PPS and add related tm capabilities in port/level/node >> capability structures. >> >> This patch also updates tm port/level/node capability structures with >> exiting features of scheduler wfq packet mode, scheduler wfq byte mode >> and private/shared shaper byte mode. >> >> SoftNIC PMD is also updated with new capabilities. >> >> Signed-off-by: Nithin Dabilpuram <ndabilpu...@marvell.com> >> --- >> v3..v4: >> - Update text under packet_mode as per Cristian. >> - Update rte_eth_softnic_tm.c based on Jasvinder's comments. >> - Add error enum RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PACKET_MODE >> - Fix shaper_profile_check() with packet mode check >> - Fix typo's >> > > Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com> >
Hi Nithin, It looks like patch is causing ABI break, I am getting following warning [1], can you please check? [1] https://pastebin.com/XYNFg14u