> -----Original Message----- > From: Yigit, Ferruh <[email protected]> > Sent: Saturday, April 25, 2020 9:09 PM > To: Dumitrescu, Cristian <[email protected]>; Nithin Dabilpuram > <[email protected]>; Singh, Jasvinder <[email protected]>; > Thomas Monjalon <[email protected]>; Andrew Rybchenko > <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; Nithin > Dabilpuram <[email protected]> > Subject: Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt > mode > > On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: > > > > > >> -----Original Message----- > >> From: Nithin Dabilpuram <[email protected]> > >> Sent: Wednesday, April 22, 2020 6:21 PM > >> To: Singh, Jasvinder <[email protected]>; Dumitrescu, Cristian > >> <[email protected]>; Thomas Monjalon > >> <[email protected]>; Yigit, Ferruh <[email protected]>; Andrew > >> Rybchenko <[email protected]> > >> Cc: [email protected]; [email protected]; [email protected]; Nithin > >> Dabilpuram <[email protected]> > >> Subject: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt > >> mode > >> > >> From: Nithin Dabilpuram <[email protected]> > >> > >> Some NIC hardware support shaper to work in packet mode i.e > >> shaping or ratelimiting traffic is in packets per second (PPS) as > >> opposed to default bytes per second (BPS). Hence this patch > >> adds support to configure shared or private shaper in packet mode, > >> provide rate in PPS and add related tm capabilities in port/level/node > >> capability structures. > >> > >> This patch also updates tm port/level/node capability structures with > >> exiting features of scheduler wfq packet mode, scheduler wfq byte mode > >> and private/shared shaper byte mode. > >> > >> SoftNIC PMD is also updated with new capabilities. > >> > >> Signed-off-by: Nithin Dabilpuram <[email protected]> > >> --- > >> v3..v4: > >> - Update text under packet_mode as per Cristian. > >> - Update rte_eth_softnic_tm.c based on Jasvinder's comments. > >> - Add error enum > RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PACKET_MODE > >> - Fix shaper_profile_check() with packet mode check > >> - Fix typo's > >> > > > > Acked-by: Cristian Dumitrescu <[email protected]> > > > > Hi Nithin, > > It looks like patch is causing ABI break, I am getting following warning [1], > can you please check? > > [1] > https://pastebin.com/XYNFg14u
Hi Ferruh, The RTE_TM API is marked as experimental, but it looks that this was not correctly marked when __rte_experimental ABI checker was introduced. It is marked as experimental at the top of the rte_tm.h, similarly to other APIs introduced around same time, but it was not correctly picked up by the ABI check procedure when later introduced, so __rte_experimental was not added to every function. Regards, Cristian
