Hi, Maxime It seems there are some typos (see below). Beside these ones - ACKed.
> -----Original Message----- > From: Maxime Leroy <[email protected]> > Sent: Monday, November 16, 2020 19:03 > To: Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; > Slava Ovsiienko <[email protected]>; Olivier Matz > <[email protected]> > Cc: [email protected]; Didier Pallard <[email protected]> > Subject: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value > > From: Didier Pallard <[email protected]> > > Three bugs in rx_queue_count function: > - One entry may contain several segments, so 'used' must be multiplied > by number of segments per entry to properly reflect the queue usage. > - The number of cqes is equals to (1U << rxq->elts_n) - 1 in non mqrt > mode. The range returned by rx_queue_count should be the number of Should it be "bullet number 3" ? > entries used in queue, so it ranges from 0 to max number of entries > in queue, not this number minus one. WARNING:TYPO_SPELLING: 'acount' may be misspelled - perhaps 'account'? Should it be - "to take into account?" Should it be "MPRQ" ? > - For MQRT mode, we need to take acount of the number of strd. > > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") > Signed-off-by: Didier Pallard <[email protected]> > Signed-off-by: Maxime Leroy <[email protected]> Acked-by: Viacheslav Ovsiienko <[email protected]>
