Hi Slava, On Mon, Nov 16, 2020 at 9:03 PM Slava Ovsiienko <viachesl...@nvidia.com> wrote: > > Hi, Maxime > > It seems there are some typos (see below). > Beside these ones - ACKed. > > > -----Original Message----- > > From: Maxime Leroy <maxime.le...@6wind.com> > > Sent: Monday, November 16, 2020 19:03 > > To: Matan Azrad <ma...@nvidia.com>; Shahaf Shuler <shah...@nvidia.com>; > > Slava Ovsiienko <viachesl...@nvidia.com>; Olivier Matz > > <olivier.m...@6wind.com> > > Cc: dev@dpdk.org; Didier Pallard <didier.pall...@6wind.com> > > Subject: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value > > > > From: Didier Pallard <didier.pall...@6wind.com> > > > > Three bugs in rx_queue_count function: > > - One entry may contain several segments, so 'used' must be multiplied > > by number of segments per entry to properly reflect the queue usage. > > - The number of cqes is equals to (1U << rxq->elts_n) - 1 in non mqrt > > mode. The range returned by rx_queue_count should be the number of > > Should it be "bullet number 3" ?
This bullet is for SPRQ mode. The bullet number 3 is for MPRQ mode. Not sure to understand your point. > > > entries used in queue, so it ranges from 0 to max number of entries > > in queue, not this number minus one. > > WARNING:TYPO_SPELLING: 'acount' may be misspelled - perhaps 'account'? > Should it be - "to take into account?" > Should it be "MPRQ" ? I will fix it in V4. Thanks for the review. > > > - For MQRT mode, we need to take acount of the number of strd. > > > > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") > > Signed-off-by: Didier Pallard <didier.pall...@6wind.com> > > Signed-off-by: Maxime Leroy <maxime.le...@6wind.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> >