On 12-Jan-21 8:32 PM, Lance Richardson wrote:
On Thu, Dec 17, 2020 at 9:08 AM Anatoly Burakov
<anatoly.bura...@intel.com> wrote:
From: Liang Ma <liang.j...@intel.com>
Add a simple API to allow getting the monitor conditions for
power-optimized monitoring of the RX queues from the PMD, as well as
release notes information.
Signed-off-by: Liang Ma <liang.j...@intel.com>
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>
---
<snip>
/**
* @internal A structure containing the functions exported by an Ethernet
driver.
*/
@@ -917,6 +937,8 @@ struct eth_dev_ops {
/**< Set up the connection between the pair of hairpin queues. */
eth_hairpin_queue_peer_unbind_t hairpin_queue_peer_unbind;
/**< Disconnect the hairpin queues of a pair from each other. */
+ eth_get_monitor_addr_t get_monitor_addr;
+ /**< Get next RX queue ring entry address. */
};
The implementation of get_monitor_addr will have much in common with
the rx_descriptor_status API in struct rte_eth_dev, including the property
that it will likely not make sense for it to be called concurrently with
rx_pkt_burst on a given queue. Might it make more sense to have this
API in struct rte_eth_dev instead of struct eth_dev_ops?
I don't have an opinion on this as this code isn't really my area of
expertise. I'm fine with wherever the community thinks this code should
be. Any other opinions?
--
Thanks,
Anatoly
