08/01/2021 15:30, David Hunt: > From: Bruce Richardson <bruce.richard...@intel.com> > > Move the 2 public functions into rte_power_guest_channel.h [...] > +/** > + * Send a message contained in pkt over the Virtio-Serial to the host > endpoint. > + * > + * @param pkt > + * Pointer to a populated struct channel_packet > + * > + * @param lcore_id > + * lcore_id. > + * > + * @return > + * - 0 on success. > + * - Negative on error. > + */ > +int rte_power_guest_channel_send_msg(struct channel_packet *pkt, > + unsigned int lcore_id); > + > +/** > + * Receive a message contained in pkt over the Virtio-Serial > + * from the host endpoint. > + * > + * @param pkt > + * Pointer to channel_packet or > + * channel_packet_freq_list struct. > + * > + * @param pkt_len > + * Size of expected data packet. > + * > + * @param lcore_id > + * lcore_id. > + * > + * @return > + * - 0 on success. > + * - Negative on error. > + */ > +__rte_experimental > +int > +rte_power_guest_channel_receive_msg(void *pkt, > + size_t pkt_len, > + unsigned int lcore_id);
Why only the second one is experimental? Given the uncertainty of this API, I think it should be all experimental.