> -----Original Message-----
> From: Thomas Monjalon <[email protected]>
> Sent: Monday, March 22, 2021 06:31
> To: [email protected]
> Cc: [email protected]; [email protected]; Ajit Khaparde
> <[email protected]>; Richardson, Bruce
> <[email protected]>; Andrew Rybchenko
> <[email protected]>; Li, Xiaoyun <[email protected]>; Ori
> Kam <[email protected]>; Bing Zhao <[email protected]>; Iremonger, Bernard
> <[email protected]>; Jens Freimann <[email protected]>;
> Kevin Traynor <[email protected]>; Stephen Hemminger
> <[email protected]>; Maciej Czekaj
> <[email protected]>; De Lara Guarch, Pablo
> <[email protected]>
> Subject: [PATCH v4 11/11] app/testpmd: fix usage text
>
> The options help text was including an incomplete and redundant summary of
> the options before explaining each. The summary is dropped.
>
> The details of the option --hairpin-mode had an extra space, breaking the
> alignment with the next line.
>
> There were some mismatches between options in the usage text
> sed -rn 's/.*\(" *--([a-z-]*)[=: ].*/\1/p' app/test-pmd/parameters.c and
> the options declared in lgopts array
> sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p' app/test-pmd/parameters.c The
> misses were:
> --no-numa
> --enable-scatter
> --tx-ip
> --tx-udp
> --noisy-lkup-num-reads-writes
> The option --ports was not implemented.
>
> Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
> Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode")
> Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP
> parameters")
> Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option")
> Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default")
> Fixes: af75078fece3 ("first public release")
> Cc: [email protected]
>
> Signed-off-by: Thomas Monjalon <[email protected]>
> Acked-by: Ajit Khaparde <[email protected]>
> Acked-by: Bruce Richardson <[email protected]>
> Acked-by: Andrew Rybchenko <[email protected]>
> ---
Acked-by: Xiaoyun Li <[email protected]>
