On 4/14/2021 2:12 PM, Thomas Monjalon wrote:
13/04/2021 09:00, Dmitry Kozlyuk:
Hi Ranjit,
2021-04-12 21:46 (UTC-0700), Ranjit Menon:
[...]
The change to remove the networking shim breaks l2fwd compilation on
Windows, since l2fwd/main.c includes netinet/in.h explicitly.
How do you propose we fix this, only for Windows?
This include is redundant for this file on all platforms, it can be removed.
Since -Dexamples=all doesn't work on Windows because of missing dependencies,
I wonder which of them need fixing.
Let's fix the examples which are supported on Windows.
Other examples may require more updates anyway.
Thanks, Thomas. For now, this is only required in l2fwd.
Dmitry, can you please include this in your patch 4/4?
thanks,
ranjit m.
