On 4/14/2021 2:42 PM, Thomas Monjalon wrote:
14/04/2021 23:34, Ranjit Menon:
On 4/14/2021 2:12 PM, Thomas Monjalon wrote:
13/04/2021 09:00, Dmitry Kozlyuk:
Hi Ranjit,
2021-04-12 21:46 (UTC-0700), Ranjit Menon:
[...]
The change to remove the networking shim breaks l2fwd compilation on
Windows, since l2fwd/main.c includes netinet/in.h explicitly.
How do you propose we fix this, only for Windows?
This include is redundant for this file on all platforms, it can be removed.
Since -Dexamples=all doesn't work on Windows because of missing dependencies,
I wonder which of them need fixing.
Let's fix the examples which are supported on Windows.
Other examples may require more updates anyway.
Thanks, Thomas. For now, this is only required in l2fwd.
Only l2fwd is supported on Windows?
Dmitry, can you please include this in your patch 4/4?
Ranjit, if you tell me what exactly is needed, I can do it
and merge the series quickly.
Sure, Thomas. In l2wfd/main.c, all we need to do is remove the #include
<netinet/in.h> line.
This include file will not exist on Windows anymore, and Dmitry
determined that this include is not required in l2fwd on all platforms.
ranjit m.
