07/04/2021 18:10, David Hunt: > Hi Anatoly, > > On 7/4/2021 4:56 PM, Anatoly Burakov wrote: > > Previous fix has addressed the incorrect handling of `base_frequency` > > file, but has added a use-after-free error due to the fact that all > > further code paths will lead to an `fclose()` call at the end, so the > > additional `fclose()` call right after processing the file was > > unnecessary. > > > > Coverity issue: 369901 > > > > Fixes: 8a5febaac4f7 ("power: fix P-state base frequency handling") > > > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com> > > Yes, removing the fclose will do it. Either that or add an "f_base = > NULL" after the fclose, but the fclose removal is fine. > > Acked-by: David Hunt <david.h...@intel.com>
Applied, thanks