Thank you, Cristian, appreciate this extra effort! Regards, Asaf Penso
>-----Original Message----- >From: dev <[email protected]> On Behalf Of Dumitrescu, Cristian >Sent: Tuesday, April 20, 2021 2:18 PM >To: Jiawei(Jonny) Wang <[email protected]>; Matan Azrad ><[email protected]>; Ori Kam <[email protected]>; Slava Ovsiienko ><[email protected]>; Shahaf Shuler <[email protected]>; Wisam >Monther <[email protected]>; Li, Xiaoyun <[email protected]>; Singh, >Jasvinder <[email protected]>; NBU-Contact-Thomas Monjalon ><[email protected]>; Yigit, Ferruh <[email protected]>; Andrew >Rybchenko <[email protected]>; Ray Kinsella ><[email protected]>; Neil Horman <[email protected]> >Cc: [email protected]; Raslan Darawsheh <[email protected]>; Roni Bar Yanai ><[email protected]>; Li Zhang <[email protected]>; Haifei Luo ><[email protected]> >Subject: Re: [dpdk-dev] [PATCH v9 1/2] ethdev: add pre-defined meter policy >API > > > >> -----Original Message----- >> From: Jiawei Wang <[email protected]> >> Sent: Monday, April 19, 2021 5:08 PM >> To: [email protected]; [email protected]; [email protected]; >> [email protected]; Wisam Jaddo <[email protected]>; Li, Xiaoyun >> <[email protected]>; Singh, Jasvinder <[email protected]>; >> Dumitrescu, Cristian <[email protected]>; Thomas Monjalon >> <[email protected]>; Yigit, Ferruh <[email protected]>; Andrew >> Rybchenko <[email protected]>; Ray Kinsella >> <[email protected]>; Neil Horman <[email protected]> >> Cc: [email protected]; [email protected]; [email protected]; Li Zhang >> <[email protected]>; Haifei Luo <[email protected]> >> Subject: [PATCH v9 1/2] ethdev: add pre-defined meter policy API >> >> From: Li Zhang <[email protected]> >> >> Currently, the flow meter policy does not support multiple actions per >> color; also the allowed action types per color are very limited. >> In addition, the policy cannot be pre-defined. >> >> Due to the growing in flow actions offload abilities there is a >> potential for the user to use variety of actions per color differently. >> This new meter policy API comes to allow this potential in the most >> ethdev common way using rte_flow action definition. >> A list of rte_flow actions will be provided by the user per color in >> order to create a meter policy. >> In addition, the API forces to pre-define the policy before the meters >> creation in order to allow sharing of single policy with multiple >> meters efficiently. >> >> meter_policy_id is added into struct rte_mtr_params. >> So that it can get the policy during the meters creation. >> >> Allow coloring the packet using a new rte_flow_action_color as could >> be done by the old policy API. >> >> Add two common policy template as macros in the head file. >> >> The next API function were added: >> - rte_mtr_meter_policy_add >> - rte_mtr_meter_policy_delete >> - rte_mtr_meter_policy_update >> - rte_mtr_meter_policy_validate >> The next struct was changed: >> - rte_mtr_params >> - rte_mtr_capabilities >> The next API was deleted: >> - rte_mtr_policer_actions_update >> >> To support this API the following app were changed: >> app/test-flow-perf: clean meter policer >> app/testpmd: clean meter policer >> >> To support this API the following drivers were changed: >> net/softnic: support meter policy API >> 1. Cleans meter rte_mtr_policer_action. >> 2. Supports policy API to get color action as policer action did. >> The color action will be mapped into rte_table_action_policer. >> >> net/mlx5: clean meter creation management Cleans and breaks part of >> the current meter management in order to allow better design with >> policy API. >> >> Signed-off-by: Li Zhang <[email protected]> >> Signed-off-by: Haifei Luo <[email protected]> >> Signed-off-by: Jiawei Wang <[email protected]> >> Acked-by: Matan Azrad <[email protected]> >> Acked-by: Ray Kinsella <[email protected]> >> Acked-by: Ori Kam <[email protected]> >> Acked-by: Jasvinder Singh <[email protected]> > >Acked-by: Cristian Dumitrescu <[email protected]>
