Hi Thomas, Thanks for your comments. Since this patch already accepted, I will fix it in RC2.
Regards, Li Zhang > -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Thursday, April 22, 2021 3:44 AM > To: Jiawei(Jonny) Wang <[email protected]> > Cc: Matan Azrad <[email protected]>; Ori Kam <[email protected]>; Slava > Ovsiienko <[email protected]>; Shahaf Shuler <[email protected]>; > [email protected]; Wisam Monther <[email protected]>; Xiaoyun Li > <[email protected]>; Jasvinder Singh <[email protected]>; Cristian > Dumitrescu <[email protected]>; Andrew Rybchenko > <[email protected]>; Ray Kinsella <[email protected]>; > [email protected]; Raslan Darawsheh <[email protected]>; Roni Bar Yanai > <[email protected]>; Asaf Penso <[email protected]>; Li Zhang > <[email protected]>; Haifei Luo <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy > API > > External email: Use caution opening links or attachments > > > 20/04/2021 16:04, Jiawei Wang: > > --- a/doc/guides/rel_notes/release_21_05.rst > > +++ b/doc/guides/rel_notes/release_21_05.rst > > @@ -244,6 +244,27 @@ New Features > > * Added support for crypto adapter forward mode in octeontx2 event and > crypto > > device driver. > > > > + * deleted the port meter policer action command . > > + ``set port meter policer action (port_id) (mtr_id) (action_mask) > > + ...`` > > + * Added command to create meter policy. > > + ``add port meter policy (port_id) (policy_id) g_actions {action} > > + end y_actions {action} end r_actions {action} end`` > > + * Added command to delete meter policy. > > + ``del port meter policy (port_id) (policy_id)`` > > + > > +* **Updated meter API.** > > + > > + * ethdev: Deleted meter policer API to support policy API. > > + ``rte_mtr_policer_actions_update()`` > > + * ethdev: Added meter API to support pre-defined policy, rte_flow action > list per color. > > + ``rte_mtr_meter_policy_add()``, ``rte_mtr_meter_policy_delete()`` and > > + ``rte_mtr_create_with_policy()`` > > + * ethdev: Removed rte_mtr_policer_action from rte_mtr_params > structures. > > + * ethdev: Added rte_mtr_meter_policy_params structures to support > policy API. > > + * ethdev: Added meter_policy_id into rte_mtr_params structures. > > + * ethdev: Removed policer_action_recolor_supported and > policer_action_drop_supported from rte_mtr_capabilities structures. > > + * ethdev: Added meter_policy_n_max into rte_mtr_capabilities structures. > > + * ethdev: Added RTE_FLOW_ACTION_TYPE_METER_COLOR in enum > rte_flow_action_type. > > + * ethdev: Added RTE_MTR_ERROR_TYPE_METER_POLICY_ID and > RTE_MTR_ERROR_TYPE_METER_POLICY_ID into rte_mtr_error_type. > > What is this garbage? > Wrong place, wrong format, wrong everything. > > I would like to see a bit more attention to details, especially in a rush to > close > the -rc1. >
