I didn't plan to have it in this release since it's not critical and I'm afraid of such changes... I didn't mention this in the status mail today. @Raslan Darawsheh<mailto:rasl...@nvidia.com> can we check tomorrow regression result? If not good we'll need to revert it.
Regards, Asaf Penso ________________________________ From: Thomas Monjalon <tho...@monjalon.net> Sent: Tuesday, May 18, 2021 12:43:34 PM To: Alexander Kozyrev <akozy...@nvidia.com> Cc: dev@dpdk.org <dev@dpdk.org>; sta...@dpdk.org <sta...@dpdk.org>; Raslan Darawsheh <rasl...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Asaf Penso <as...@nvidia.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field > > The modify_field Flow API assumes that the META item is 32 bits wide. > > But the C Register that is used for Meta item can be 16 or 32 bits wide > > depending on kernel and firmware configurations. > > Take this into consideration and use the appropriate META width. > > > > Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Alexander Kozyrev <akozy...@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> Applied in next-net-mlx, thanks.