Yes, It is palliative, it is not perfect, and, IMO, it is crucial - with always applying 32-bit wide values we can destroy the kernel part of reg_c0 in some extended metadata modes and this would lead to steering malfunction.
With best regards, Slava From: Asaf Penso <[email protected]> Sent: Tuesday, May 18, 2021 14:33 To: NBU-Contact-Thomas Monjalon <[email protected]>; Alexander Kozyrev <[email protected]>; Raslan Darawsheh <[email protected]> Cc: [email protected]; [email protected]; Raslan Darawsheh <[email protected]>; Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field I didn't plan to have it in this release since it's not critical and I'm afraid of such changes... I didn't mention this in the status mail today. @Raslan Darawsheh<mailto:[email protected]> can we check tomorrow regression result? If not good we'll need to revert it. Regards, Asaf Penso ________________________________ From: Thomas Monjalon <[email protected]<mailto:[email protected]>> Sent: Tuesday, May 18, 2021 12:43:34 PM To: Alexander Kozyrev <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; Raslan Darawsheh <[email protected]<mailto:[email protected]>>; Matan Azrad <[email protected]<mailto:[email protected]>>; Slava Ovsiienko <[email protected]<mailto:[email protected]>>; Asaf Penso <[email protected]<mailto:[email protected]>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field > > The modify_field Flow API assumes that the META item is 32 bits wide. > > But the C Register that is used for Meta item can be 16 or 32 bits wide > > depending on kernel and firmware configurations. > > Take this into consideration and use the appropriate META width. > > > > Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") > > Cc: [email protected]<mailto:[email protected]> > > > > Signed-off-by: Alexander Kozyrev > > <[email protected]<mailto:[email protected]>> > Acked-by: Viacheslav Ovsiienko > <[email protected]<mailto:[email protected]>> Applied in next-net-mlx, thanks.
