> v2:
> - Add data-path part.
>
> v3:
> - Rebase.
>
> v4:
> - Rebase + Address the following Akhil comments:
> - Set HW feature flag in the capability patch.
> - Fix mp object release in session clear.
> - Some spelling and word missing in doc.
> - Squash data-unit adjustment to the session operations commit.
> - Wording: device argument -> devarg.
>
> v5:
> - Add mlx5 crypto tests into test library.
> - Update documentation according to Akhil comments.
> - Fix memory region management.
> - Fix multi segment case in data-path code.
> - Split documentation to the correct commits according to Akhil comments.
> - Rebase to new version.
> - Change license to Nvidia license.
>
> v6:
> - Rebase to new version.
> - Address David's comment and update log accordingly.
> - Update testing app commits as suggested by Akhil.
>
> v7:
> - Rebase to new version.
> - Add scatter gather and OOP test cases.
>
> v8:
> - Add a test case that was removed by error.
>
>
>
> Shiri Kuzin (11):
> drivers: introduce mlx5 crypto PMD
> crypto/mlx5: add DEK object management
This is really bad, I was planning to apply this series today,
It had small issues, so was planning to fix them while applying.
But when I applied the 2/16, it does not compile.
Please fix this, we are into v8 and compilation is broken.
I am adding few more comments, please fix them too in your next version
As soon as possible. I was planning to close RC2 during weekend, but it looks
It will fall over next week.
147 | mlx5_crypto_dek_match_cb,
| ^~~~~~~~~~~~~~~~~~~~~~~~
| |
| int (*)(void *, struct mlx5_list_entry *, void *)
In file included from ../drivers/crypto/mlx5/mlx5_crypto.h:13,
from ../drivers/crypto/mlx5/mlx5_crypto_dek.c:14:
../drivers/common/mlx5/mlx5_common_utils.h:138:20: note: expected
'mlx5_hlist_remove_cb' {aka 'void (*)(struct mlx5_hlist *, struct
mlx5_hlist_entry *)'} but argument is of type 'int (*)(void *, struct
mlx5_list_entry *, void *)'
138 | struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t size,
| ^~~~~~~~~~~~~~~~~
../drivers/crypto/mlx5/mlx5_crypto_dek.c:144:20: error: too many arguments to
function 'mlx5_hlist_create'
144 | priv->dek_hlist = mlx5_hlist_create("dek_hlist",
| ^~~~~~~~~~~~~~~~~
In file included from ../drivers/crypto/mlx5/mlx5_crypto.h:13,
from ../drivers/crypto/mlx5/mlx5_crypto_dek.c:14:
../drivers/common/mlx5/mlx5_common_utils.h:138:20: note: declared here
138 | struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t size,
| ^~~~~~~~~~~~~~~~~
../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_destroy':
../drivers/crypto/mlx5/mlx5_crypto_dek.c:26:1: error: control reaches end of
non-void function [-Werror=return-type]
26 | }
| ^
../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_prepare':
../drivers/crypto/mlx5/mlx5_crypto_dek.c:45:1: error: control reaches end of
non-void function [-Werror=return-type]
45 | }
| ^
../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function
'mlx5_crypto_dek_create_cb':
../drivers/crypto/mlx5/mlx5_crypto_dek.c:127:1: error: control reaches end of
non-void function [-Werror=return-type]
127 | }
| ^
cc1: all warnings being treated as errors
