> -----Original Message-----
> From: Suanming Mou <suanmi...@nvidia.com>
> Sent: Tuesday, July 20, 2021 2:29 PM
> To: Akhil Goyal <gak...@marvell.com>; Shiri Kuzin <shi...@nvidia.com>;
> dev@dpdk.org
> Cc: Matan Azrad <ma...@nvidia.com>; david.march...@redhat.com
> Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations
>
>
>
> > -----Original Message-----
> > From: Akhil Goyal <gak...@marvell.com>
> > Sent: Saturday, July 17, 2021 3:40 AM
> > To: Shiri Kuzin <shi...@nvidia.com>; dev@dpdk.org
> > Cc: Matan Azrad <ma...@nvidia.com>; Suanming Mou
> > <suanmi...@nvidia.com>; david.march...@redhat.com
> > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations
> > > doc/guides/cryptodevs/mlx5.rst | 10 ++
> > > drivers/crypto/mlx5/mlx5_crypto.c | 172 +++++++++++++++++++++++-
> > > 3 files changed, 182 insertions(+), 5 deletions(-)
> > >
> > > static const struct rte_driver mlx5_drv = { @@ -39,6 +68,49 @@ static
> > > const struct rte_driver mlx5_drv = {
> > >
> > > static struct cryptodev_driver mlx5_cryptodev_driver;
> > >
> > > +struct mlx5_crypto_session {
> > > + uint32_t bs_bpt_eo_es;
> > > + /*
> > > + * bsf_size, bsf_p_type, encryption_order and encryption standard,
> > > + * saved in big endian format.
> > > + */
> >
> > Normally the comments are added before the variable. Or add /**< for
> post
> > comment.
>
> Yes, you are right for the "normal" case, I think the main reason here is that
> all the mlx related PMDs are putting the comment after the variable, so in
> fact put the comments after the variable is the normal case for mlx PMDs.
> Let's try to keep it in normal case to not make other mlx PMD familiar
> developers confusing.
>
Please use "/**<" for post commenting.
