Re: [dpdk-dev] [EXT] [PATCH v8 01/16] drivers: introduce mlx5 crypto PMD

[Suanming Mou]

> -----Original Message-----
> From: Akhil Goyal <gak...@marvell.com>
> Sent: Saturday, July 17, 2021 3:19 AM
> To: Shiri Kuzin <shi...@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <ma...@nvidia.com>; Suanming Mou
> <suanmi...@nvidia.com>; david.march...@redhat.com
> Subject: RE: [EXT] [PATCH v8 01/16] drivers: introduce mlx5 crypto PMD
> 
> > diff --git a/doc/guides/rel_notes/release_21_08.rst
> > b/doc/guides/rel_notes/release_21_08.rst
> > index 7d289e07e3..2bf4ce7a73 100644
> > --- a/doc/guides/rel_notes/release_21_08.rst
> > +++ b/doc/guides/rel_notes/release_21_08.rst
> > @@ -125,6 +125,11 @@ New Features
> >    The experimental PMD power management API now supports managing
> >    multiple Ethernet Rx queues per lcore.
> >
> > +* **Added support for Nvidia crypto device driver.**
> > +
> > +  * Added mlx5 crypto driver to support AES-XTS cipher operations.
> > +    The first device to support it is ConnectX-6.
> > +
> 
> Update release notes when the feature is complete.
> Probably in your enq/deq patch (12/16)

I assume it should  be (13/16)? Since this patch finishes implementing all the 
callbacks.

> 
> 
> > +static const struct rte_pci_id mlx5_crypto_pci_id_map[] = {
> > +           {
> > +                   RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> > +
> >     PCI_DEVICE_ID_MELLANOX_CONNECTX6)
> > +           },
> > +           {
> > +                   .vendor_id = 0
> > +           }
> > +   };
> 
> Fix indentation.

Good catch.

> 
> > +