> -----Original Message----- > From: Cyril Chemparathy [mailto:cchemparathy at ezchip.com] > Sent: Tuesday, June 23, 2015 9:43 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 08/12] mempool: allow config override on > element alignment > > On Tue, 23 Jun 2015 00:31:06 +0000 > "Ananyev, Konstantin" <konstantin.ananyev at intel.com> wrote: > > > > +#define RTE_MEMPOOL_ALIGN_MASK (RTE_MEMPOOL_ALIGN - 1) > > > > I am probably a bit late with my comments, but why not make it a > > runtime decision then? I know we can't add a new parameter to > > mempool_xmem_create() without ABI breakage, but we can make some > > global variable for now, that could be setup at init time or > > something similar. > > But then, a global variable that is modified by an application _is_ a > part of the ABI, and a bad one at that. > > I agree with the desire to make it runtime configurable, but I think we > should do so in the right spirit, with the appropriate interfaces, and > when we're open to changing the ABI accordingly.
Ok, let's wait till next release then. Konstantin > > Thanks > -- Cyril.
