26/10/2021 10:24, Liu, Yu Y: > Hi Thomas, > > Would you merge this patch as the series is acked by Cristian as below? > https://patchwork.dpdk.org/project/dpdk/cover/[email protected]/
I didn't see any email from Cristian. It seems you just added this ack silently at the bottom of the cover letter. 1/ an email from Cristian is far better 2/ when integrating ack, it must be done in patches, not cover letter > > Thanks & Regards, > Yu Liu > > -----Original Message----- > From: dev <[email protected]> On Behalf Of Liguzinski, WojciechX > Sent: Monday, October 25, 2021 7:32 PM > To: [email protected]; Singh, Jasvinder <[email protected]>; Dumitrescu, > Cristian <[email protected]> > Cc: Ajmera, Megha <[email protected]> > Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem which is a situation when excess buffers in the network > cause high latency and latency variation. Currently, it supports RED for > active queue management. However, more advanced queue management is required > to address this problem and provide desirable quality of service to users. > > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral controller Enhanced) that can effectively and directly > control queuing latency to address the bufferbloat problem. > > The implementation of mentioned functionality includes modification of > existing and adding a new set of data structures to the library, adding PIE > related APIs. > This affects structures in public API/ABI. That is why deprecation notice is > going to be prepared and sent. > > Liguzinski, WojciechX (5): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support > doc/guides/prog_guide: added PIE > app/test: add tests for PIE > > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > config/rte_config.h | 1 - > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 64 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 142 +-- > examples/qos_sched/cfg_file.c | 127 ++- > examples/qos_sched/cfg_file.h | 5 + > examples/qos_sched/init.c | 27 +- > examples/qos_sched/main.h | 3 + > examples/qos_sched/profile.cfg | 196 ++-- > lib/sched/meson.build | 3 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 241 ++-- > lib/sched/rte_sched.h | 63 +- > lib/sched/version.map | 4 + > 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 > app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode > 100644 lib/sched/rte_pie.h > > -- > 2.25.1 > > Series-acked-by: Cristian Dumitrescu <[email protected]> >
