Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Friday, October 29, 2021 2:58 PM
> To: Dumitrescu, Cristian <cristian.dumitre...@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>; Ajmera,
> Megha <megha.ajm...@intel.com>; Liguzinski, WojciechX
> <wojciechx.liguzin...@intel.com>; david.march...@redhat.com; Mcnamara,
> John <john.mcnam...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion
> management
> 
> 28/10/2021 12:17, Liguzinski, WojciechX:
> > Implement PIE based congestion management based on rfc8033
> 
> An explanation is missing about why RED code is removed.
> I don't know whether it deserves a separate commit,
> but at least it should be removed consisently in lib and example code
> in the same patch.
> 
> Cristian, please make efforts to help this patchset be properly organized.
> A blind ack is not enough.
> 

The RED code is not removed. It is simply the macro renamed to CMAN (Congestion 
Management) to include both RED and PIE.