On 2/15/2022 10:18 AM, Robin Zhang wrote:
This patch add a format specific information of different module eeprom. The format support for SFP(Small Formfactor Pluggable)/SFP+ /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on SFF(Small Form Factor) Committee specifications SFF-8079/SFF-8472/SFF-8024/SFF-8636.
Hi Robin, First of all, can you please clarify the motivation of this patch? Why we are adding this eeprom parsing, and who will be user of this patch? And, just to confirm, this parses the eeprom module based on SFF spec, right? So it doesn't specific or depends any vendor. But still, this is too much SFF specific code in the testpmd, and it is not small amount of code. I am not comfortable to get this into testpmd unless there is a good reason. What do you think to have this as a sample application?
Signed-off-by: Robin Zhang <robinx.zh...@intel.com> --- app/test-pmd/cmdline.c | 74 +- app/test-pmd/config.c | 24 +- app/test-pmd/meson.build | 4 + app/test-pmd/sff_8079.c | 376 ++++++++++ app/test-pmd/sff_8472.c | 281 ++++++++ app/test-pmd/sff_8636.c | 742 ++++++++++++++++++++ app/test-pmd/sff_8636.h | 592 ++++++++++++++++ app/test-pmd/sff_common.c | 296 ++++++++ app/test-pmd/sff_common.h | 178 +++++ app/test-pmd/testpmd.h | 13 +- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +- 11 files changed, 2575 insertions(+), 16 deletions(-) create mode 100644 app/test-pmd/sff_8079.c create mode 100644 app/test-pmd/sff_8472.c create mode 100644 app/test-pmd/sff_8636.c create mode 100644 app/test-pmd/sff_8636.h create mode 100644 app/test-pmd/sff_common.c create mode 100644 app/test-pmd/sff_common.h
<...>
