Hi Nicolas,
On 6/7/22 17:44, Chautru, Nicolas wrote:
Hi Maxime,
-----Original Message-----
From: Maxime Coquelin <maxime.coque...@redhat.com>
Sent: Tuesday, June 7, 2022 5:43 AM
To: Stephen Hemminger <step...@networkplumber.org>; Chautru, Nicolas
<nicolas.chau...@intel.com>
Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com;
hemant.agra...@nxp.com; Vargas, Hernan <hernan.var...@intel.com>
Subject: Re: [PATCH v1] bbdev: add device status info
Hi Stephen,
On 6/7/22 02:09, Stephen Hemminger wrote:
On Mon, 6 Jun 2022 15:50:08 -0700
Nicolas Chautru <nicolas.chau...@intel.com> wrote:
@@ -298,6 +313,8 @@ struct rte_bbdev_driver_info {
const struct rte_bbdev_op_cap *capabilities;
/** Device cpu_flag requirements */
const enum rte_cpu_flag_t *cpu_flag_reqs;
+ /** Device Status */
+ enum rte_bbdev_device_status device_status;
};
This ends up being an ABI breakage, can't change a struct like that
until 22.11 release.
Indeed, but Nicolas mentioned in the cover-letter that the patch targets
v22.11; not this release.
However, a deprecation notice should be sent for v22.07 if it hasn't been
done yet.
I have sent this deprecation Maxime:
https://patches.dpdk.org/project/dpdk/patch/1647542252-35727-2-git-send-email-nicolas.chau...@intel.com/
Do you believe this needs to be extended to cover more details the change and
including this device status info explicitly? I can update the verbiage in more
details if required
Thanks for the pointer, I missed it.
Reading the deprecation notice, it is not clear to me it is about the
device status info enum.
Maybe rewording it a bit to be more specific would help.
Thanks,
Maxime
Maxime
