> -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Saturday, September 24, 2022 03:01 > To: Guo, Junfeng <junfeng....@intel.com> > Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing > <jingjing...@intel.com>; ferruh.yi...@xilinx.com; dev@dpdk.org; Li, > Xiaoyun <xiaoyun...@intel.com>; awogbem...@google.com; Richardson, > Bruce <bruce.richard...@intel.com>; Lin, Xueqin <xueqin....@intel.com>; > Wang, Haiyue <haiyue.w...@intel.com> > Subject: Re: [PATCH v3 2/9] net/gve: add logs and OS specific > implementation > > On Fri, 23 Sep 2022 17:38:22 +0800 > Junfeng Guo <junfeng....@intel.com> wrote: > > > + > > +#define PMD_DRV_LOG(level, fmt, args...) \ > > + rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n", > \ > > + __func__, ## args) > > Many of your existing log messages already have newline, so using this > common definition will create double spaced log messages. > > Please audit all usages and print one newline. Sure, will double check all the usages and update in the coming version. Thanks!
- [PATCH v2 10/10] doc: update documentation Junfeng Guo
- Re: [PATCH v2 10/10] doc: update documentation Ferruh Yigit
- [PATCH v3 0/9] introduce GVE PMD Junfeng Guo
- [PATCH v3 1/9] net/gve: introduce GVE PMD base ... Junfeng Guo
- Re: [PATCH v3 1/9] net/gve: introduce GVE P... Stephen Hemminger
- RE: [PATCH v3 1/9] net/gve: introduce G... Guo, Junfeng
- Re: [PATCH v3 1/9] net/gve: introduce GVE P... Stephen Hemminger
- RE: [PATCH v3 1/9] net/gve: introduce G... Guo, Junfeng
- [PATCH v3 2/9] net/gve: add logs and OS specifi... Junfeng Guo
- Re: [PATCH v3 2/9] net/gve: add logs and OS... Stephen Hemminger
- RE: [PATCH v3 2/9] net/gve: add logs an... Guo, Junfeng
- [PATCH v3 4/9] net/gve: add link update support Junfeng Guo
- [PATCH v3 3/9] net/gve: support device initiali... Junfeng Guo
- [PATCH v3 5/9] net/gve: add MTU set support Junfeng Guo
- [PATCH v3 6/9] net/gve: add queue operations Junfeng Guo
- [PATCH v3 7/9] net/gve: add Rx/Tx support Junfeng Guo
- [PATCH v3 8/9] net/gve: add support to get dev ... Junfeng Guo
- [PATCH v3 9/9] net/gve: add stats support Junfeng Guo
- Re: [PATCH v2 00/10] introduce GVE PMD Ferruh Yigit
- RE: [PATCH v2 00/10] introduce GVE PMD Guo, Junfeng