> -----Original Message-----
> From: Thomas Monjalon <[email protected]>
> Sent: 2023年2月6日 17:16
> To: Ye, MingjinX <[email protected]>
> Cc: [email protected]; [email protected]; Zhou, YidingX
> <[email protected]>; Yang, Qiming <[email protected]>; Zhang,
> Qi Z <[email protected]>; [email protected];
> [email protected]
> Subject: Re: [PATCH] net/ice: fix get link status timeout
>
> 06/02/2023 09:14, Ye, MingjinX:
> > From: Thomas Monjalon <[email protected]>
> > > 06/02/2023 07:22, Mingjin Ye:
> > > > When hw is just started, it will immediately obtain the link
> > > > status, and the longest attempt is 1 second. Some NICs are slow to
> > > > initialize, which make it fails to obtain the link status.
> > > >
> > > > The patch fixes this issue by modifying the longest attempt to 5
> > > > seconds.
> > >
> > > What is the consequence?
> >
> > DPDK could not get link status. At this point, the link status
> > obtained through the pmd API is wrong.
> >
> > > In which case, DPDK application would be blocked during 5 seconds?
> >
> > When the dpdk application startup port is used, it will be blocked for
> > up to 5 seconds to ensure that the connection status can be obtained.
>
> I mean what is the consequence of the increase?
There will be no side effects.
> For example, if the port is not connected (no wire), are we going to wait 5
> seconds?
This will cause a wait of up to 5 seconds.
>
> I guess it's OK because it won't wait at all if using rte_eth_link_get_nowait.
> It may be interesting to note in the commit message.
The reason for pushing this patch is that the E823 NIC needs about 2 seconds
to get the link up state when the port is started, so the waiting time needs to
be extended.
Modified to 5 seconds, consistent with other timeouts of DPDK.
>
