> -----Original Message-----
> From: Abdullah Sevincer <abdullah.sevin...@intel.com>
> Subject: [PATCH v6] app/procinfo: display eventdev xstats for PMD data
>
I see you are supporting evendev stats print.
You can make the heading clear by removing "PMD data"
> +++ b/doc/guides/tools/proc_info.rst
> @@ -22,7 +22,9 @@ The application has a number of command line options:
> --show-ring[=name] | --show-mempool[=name] | --iter-mempool=name |
> --show-port-private | --version | --firmware-version | --show-rss-reta |
> --show-module-eeprom | --show-rx-descriptor queue_id:offset:num |
> - --show-tx-descriptor queue_id:offset:num ]
> + --show-tx-descriptor queue_id:offset:num | --edev-stats-enable |
> + --all-edev-queues | --edev-queue=queue_num | --all-edev-ports |
> + --edev-port=port_num | --edev-dump | --edev-reset |
> + --edev-device-stats]
>
On the design , I guess command line parameters can be simplified. So you can
simplify the code also.
1) What is the difference between "--edev-stats-enable" and
"--edev-device-stats" ?
2) You no need to have 2 parameters to specify the port info
"--edev-port=port_num" and "--all-edev-ports"
3)Similarly no need to have 2 parameters to specify queue info
"--all-edev-queues and --edev-queue=queue_num"
4) No need of "--edev-stats-enable".
5)You can perhaps have only 2 commands as below in place of all above commands.
In the below commands user can pass which "eventdev id" and "queue id" the
stats should be displayed for.
Example:
a)show-eventdev-stats=(eventdev id, queue)
show-eventdev-stats=(*,*) => Display all stats for all queues of all
eventdev ids
show-eventdev-stats=(*,1) => Display stats of queue 1of all eventdev
ids
show-eventdev-stats=(1,*) => Display stats of all queues of eventdev
id 1
show-eventdev-stats=(1,1) => Display stats of queue1 of eventdev id 1
b)reset-eventdev-stats=( eventdev id, queue)
Thanks,
Reshma
