> -----Original Message-----
> From: Jerin Jacob <jerinjac...@gmail.com>
> Sent: Tuesday, May 30, 2023 1:05 PM
> To: Vamsi Krishna Attunuru <vattun...@marvell.com>
> Cc: Yan, Zhirun <zhirun....@intel.com>; dev@dpdk.org;
> tho...@monjalon.net; Jerin Jacob Kollanukkaran <jer...@marvell.com>;
> Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; Liang, Cunming
> <cunming.li...@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>; Sunil
> Kumar Kori <sk...@marvell.com>
> Subject: [EXT] Re: [PATCH v2 4/4] app: add testgraph application
>
> External Email
>
> ----------------------------------------------------------------------
> On Mon, May 22, 2023 at 12:37 PM Vamsi Krishna Attunuru
> <vattun...@marvell.com> wrote:
>
> > > > +static int
> > > > +link_graph_nodes(uint64_t valid_nodes, uint32_t lcore_id) {
> > > > + int ret = 0;
> > > > +
> > > > + num_patterns = 0;
> > > > +
> > > > + if (valid_nodes == (TEST_GRAPH_ETHDEV_TX_NODE |
>
>
> I think, if we need to extend the C code for adding new use case, then it will
> not scale.
> IMO, We should look at more runtime and file based interface.
> Something like https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_DPDK_dpdk_blob_main_examples_ip-
> 5Fpipeline_examples_l2fwd.cli&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r
> =WllrYaumVkxaWjgKto6E_rtDQshhIhik2jkvzFyRhW8&m=__0iDgw_2lXr0YyyV
> pN3e1Ma9M5SyYMs1pUKnOgvix6u5jfs6MSprWyUh-
> sCmTDw&s=janRFWyPd7Ma3bCIvlVW1YqkAS_U9ouMGNfP1x98pmQ&e=
> In nutshell,
> 1) File based interface to kick-start the valid use case enablement
> 2) Less logic in C code and everything should be driven from config file
> 3) Allow runtime change. examples/ip_pipeline provides telent interface to
> update . Similar concept can be followed.
>
> I think, we should push the app for next release. Not on this release.
> Sorry for reviewing late.
Sure, agree with your new proposal. I will drop this patch for this release.
