On Fri, 9 Oct 2026 21:34:26 +0200 Roman Khromenok <[email protected]> wrote:
> Decode the compliance codes added by SFF-8472 Rev 12.5a and > SFF-8636 Rev 2.12, as ethtool does since commits 057c4fd and > 75d6232: > > - SFF-8472 byte 10: Fibre Channel 1600 and 3200 MBytes/s. > - SFF-8636 byte 133: SAS 24.0G, and SAS 12.0G which was defined > but not reported. > - SFF-8636 byte 138: Fibre Channel 3200 MBytes/s. > > Also decode the SFF-8472 Fibre Channel Speed 2 byte 62 (64GFC), > which byte 10 bit 1 refers to. ethtool does not decode it. > > Signed-off-by: Roman Khromenok <[email protected]> > --- AI feedback. Subject: Re: [PATCH 1/2] ethdev: decode newer SFF compliance codes Bit assignments match SFF-8472 Table 5-3 (byte 10, byte 62) and SFF-8636 Table 6-17 (bytes 133, 138). Gating byte 62 on byte 10 bit 1 is correct, and the A0 buffer is always 256 bytes so the byte 62 read is in bounds. Nothing blocking; a few small items. [PATCH 1/2] ethdev: decode newer SFF compliance codes Info: - "FC: 64GFC" breaks the naming of every other entry in this group, which all give MBytes/sec. 64GFC is 6400 MBytes/sec: if ((data[10] & (1 << 1)) && (data[62] & (1 << 0))) sff_output_field(d, name, "FC: 6400 MBytes/sec"); - Refer to the ethtool commits 057c4fd and 75d6232 with 12 character hashes and the subject in ("...") form, so they can be found without guessing.
