On Fri,  9 Oct 2026 21:34:27 +0200
Roman Khromenok <[email protected]> wrote:

> Check the SFF-8472 Fibre Channel 1600, 3200 MBytes/s and 64GFC
> codes, with 64GFC reported only when byte 10 refers to byte 62,
> and the SFF-8636 SAS 24.0G, 12.0G and Fibre Channel 3200 MBytes/s
> codes.
> 
> Add a helper to look for a value of a field reported more than
> once, such as "Transceiver type".
> 
> Signed-off-by: Roman Khromenok <[email protected]>
> ---

More AI feedback.

 
[PATCH 2/2] test: check newer SFF compliance codes
 
Info:
- Each test sets both new bits of a pair at once (byte 10 = 0x28,
  byte 133 = 0xc0), so a swapped mapping (1600 vs 3200, 24G vs
  12G) still passes. Set one bit and check the other is absent:
 
        data[133] = 0x80;       /* SAS 24.0G only */
        ...
        CHECK_FIELD_VALUE("Transceiver type", "SAS 24.0G");
        CHECK_NO_FIELD_VALUE("Transceiver type", "SAS 12.0G");
 
  Same for byte 10: 0x20 alone for 1600, then 0x08 alone for 3200.

Reply via email to