On 6/1/2016 3:13 PM, Yuanhan Liu wrote: > On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote: >> We keep a common vq structure, containing only vq related fields, >> and then split others into RX, TX and control queue respectively. >> >> Signed-off-by: Huawei Xie <huawei.xie at intel.com> >> --- >> v2: >> - don't split virtio_dev_rx/tx_queue_setup >> v3: >> - fix some 80 char warnings >> - fix other newer version checkpatch warnings >> - remove '\n' in PMD_RX_LOG > Weird, I still saw them.
Maybe missed this. > > Besides that, I found a crash issue with this patch applied. You could > easily reproduce it by: > > testpmd> start tx_first > testpmd> quit > > [82774.055297] testpmd[9661]: segfault at 94 ip 00000000004f7ef0 sp > 00007ffcb1fa > 66c0 error 4 in testpmd[400000+25b000] > ./t.pmd: line 11: 9661 Segmentation fault (core dumped) > $RTE_SDK/$RTE > _TARGET/app/testpmd -c 0x1f -n 4 -- --nb-cores=4 -i --disable-hw-vlan > --txqflags > 0xf00 --rxq=$nr_queues --txq=$nr_queues --rxd=256 --txd=256 > > --yliu > Couldn't reproduce. Seems like resource free issue. Do you test with multiple queues?