On Fri, Apr 29, 2016 at 3:34 AM, Wu, Jingjing <jingjing.wu at intel.com> wrote: > Hi, David > > For the changes on igb, ixgbe, I saw you create a new header file called > **__pci_dev_ids.h to replace the rte_pci_dev_ids.h for each driver. > But for the changes on i40e, you didn't do that way. > If you look into the base code, you will find for each Intel NIC, the device > ids are defined there, such as ixgbe_type.h; i40e_devid.h; E1000_hw.h. > > I'd prefer the way you did in i40e driver. It's clearer and with minor change.
This is what I wanted to do, but this requires a rework in kni and the pci test. -- David Marchand