On Thu, May 05, 2016 at 05:29:27AM +0000, Xie, Huawei wrote: > What I mean is firstly we split the queue, without breaking the common > setup; then introduce RX/TX specific setup calling extracted common > setup, so we don't have a chance to introduce duplicated code.
In such way, you have actually introduced duplicated code, haven't you?
You may argue, "yes, but I will fix it in a later patch." This is to
introducing a build error and fixing it later to me.
--yliu
