On Wed, 21 Jun 2017 12:06:49 +0100
Ferruh Yigit <[email protected]> wrote:
> +static struct ethtool_input_buffer {
> + int magic;
> + void *buffer;
> + size_t length;
> + struct completion *msg_received;
> + int *err;
> + u32 in_use;
> +} ethtool_input_buffer
Naming in kernel is important. This isn't kernel ethtool, so it shouldn't be
named that.
Having a single instance per system for a control interface means it won't work
if multiple apps have control channel open or in containers.
You should also do policy validation on the netlink message.
