On 6/21/2017 4:23 PM, Stephen Hemminger wrote: > On Wed, 21 Jun 2017 12:06:49 +0100 > Ferruh Yigit <ferruh.yi...@intel.com> wrote: > >> +static struct ethtool_input_buffer { >> + int magic; >> + void *buffer; >> + size_t length; >> + struct completion *msg_received; >> + int *err; >> + u32 in_use; >> +} ethtool_input_buffer > > Naming in kernel is important. This isn't kernel ethtool, so it shouldn't be > named that.
I have updated naming on v9. > > Having a single instance per system for a control interface means it won't > work > if multiple apps have control channel open or in containers. This should work for multiple add and interfaces, unci_nl_exec() serializes the requests, above struct used for output buffer indirection. I am not sure how to handle requests without serializing them ... > > You should also do policy validation on the netlink message. I will send a new version with this. >