> From: Mcnamara, John > Sent: Friday, October 13, 2017 4:41 PM > To: Yang, Zhiyong <[email protected]>; [email protected] > Cc: Yigit, Ferruh <[email protected]>; Yang, Zhiyong > <[email protected]>; Van Haaren, Harry <[email protected]> > Subject: RE: [dpdk-dev] [PATCH 8/8] doc: update port id type > > > > > -----Original Message----- > > From: dev [mailto:[email protected]] On Behalf Of Zhiyong Yang > > Sent: Friday, October 13, 2017 2:17 PM > > To: [email protected] > > Cc: Yigit, Ferruh <[email protected]>; Yang, Zhiyong > > <[email protected]> > > Subject: [dpdk-dev] [PATCH 8/8] doc: update port id type > > > > Since port id has changed from uint8_t to uint16_t in dpdk code, So update > > the change in related doc. > > > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > > Signed-off-by: Zhiyong Yang <[email protected]> > > Looks good. There is one other unchanged reference but I don't know if it is > relevant. > > CC: Harry > > $ ag "uint8_t port" doc/guides/ > doc/guides/prog_guide/eventdev.rst > 283: uint8_t port_id = 0;
No need to change this in the docs - the port here is an Eventdev port, not an Ethdev port. TL:DR; Looks good to me! -Harry
