Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, October 24, 2017 3:16 PM > To: dev@dpdk.org > Cc: Doherty, Declan <declan.dohe...@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com>; hemant.agra...@nxp.com; Nicolau, > Radu <radu.nico...@intel.com>; bor...@mellanox.com; > avia...@mellanox.com; tho...@monjalon.net; sandeep.ma...@nxp.com; > jerin.ja...@caviumnetworks.com; Mcnamara, John > <john.mcnam...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; shah...@mellanox.com; > olivier.m...@6wind.com > Subject: [PATCH v5 01/11] lib/rte_security: add security library >
If you are making a v6, I would change the title to "security: ...". Also, there is an issue described below. Regards, Pablo ... > diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile new > file mode 100644 index 0000000..af87bb2 > --- /dev/null > +++ b/lib/librte_security/Makefile ... > + > +# library name > +LIB = librte_security.a > + > +# library version > +LIBABIVER := 1 > + > +# build flags > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) There is a compilation issue when the building as shared library, because LDLIBS have not been set. You need to add the following: +LDLIBS += -lrte_eal -lrte_mempool
