Hi, I am waiting the crypto subtree to be ready before getting this series.
Some last comments below, 24/10/2017 16:15, Akhil Goyal: > +Security API - EXPERIMENTAL > +M: Akhil Goyal <[email protected]> > +M: Declan Doherty <[email protected]> > +F: lib/librte_security/ > +F: doc/guides/prog_guide/rte_security.rst > > Networking Drivers > ------------------ An additional blank line is missing. > +# build flags > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) As said by Pablo, please fix the build with LDLIBS. > +/** > + * @file rte_security.h > + * > + * RTE Security Common Definitions > + * > + */ You should add this line: @b EXPERIMENTAL: this API may change without prior notice > --- /dev/null > +++ b/lib/librte_security/rte_security_version.map > @@ -0,0 +1,13 @@ > +DPDK_17.11 { The name of this block should be EXPERIMENTAL > + global: > + > + rte_security_attach_session; > + rte_security_capabilities_get; > + rte_security_capability_get; > + rte_security_session_create; > + rte_security_session_destroy; > + rte_security_session_stats_get; > + rte_security_session_update; > + rte_security_set_pkt_metadata; > + > +}; I think you need this line: local: *;
