> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:34 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokh...@intel.com>; Chalupnik, KamilX > <kamilx.chalup...@intel.com> > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo > software driver
Optimization of the driver is not a good title, in my opinion. Instead, call out what you are actually changing. You should separate this patch into two patches, based on the two bullet points below. > > Optimization of Turbo Software driver: > - resource-hungry piece of code removed or optimized > - validation of decoder/encoder parameters put under debug flug > ... > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG Where is this macro defined? In DPDK we are avoiding the use of compile time options when possible, so it is a better idea to use a runtime option to avoid the execution of part of the code (passed through device configuration maybe?). Otherwise, compilation checking gets more difficult.