Hi, > -----Original Message----- > From: Chalupnik, KamilX > Sent: Wednesday, April 25, 2018 10:41 AM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokh...@intel.com> > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo > software driver > > > > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Tuesday, April 24, 2018 7:54 PM > > To: Chalupnik, KamilX <kamilx.chalup...@intel.com>; dev@dpdk.org > > Cc: Mokhtar, Amr <amr.mokh...@intel.com>; Chalupnik, KamilX > > <kamilx.chalup...@intel.com> > > Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of > > turbo software driver > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX > > > Chalupnik > > > Sent: Tuesday, April 17, 2018 3:34 PM > > > To: dev@dpdk.org > > > Cc: Mokhtar, Amr <amr.mokh...@intel.com>; Chalupnik, KamilX > > > <kamilx.chalup...@intel.com> > > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of > > > turbo software driver > > > > Optimization of the driver is not a good title, in my opinion. > > Instead, call out what you are actually changing. > > You should separate this patch into two patches, based on the two > > bullet points below. > > > > Ok, I will separate it and change the title. > > > > > > > Optimization of Turbo Software driver: > > > - resource-hungry piece of code removed or optimized > > > - validation of decoder/encoder parameters put under debug flug > > > > > > > ... > > > > > > > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG > > > > Where is this macro defined? > > In DPDK we are avoiding the use of compile time options when possible, > > so it is a better idea to use a runtime option to avoid the execution > > of part of the code (passed through device configuration maybe?). > > Otherwise, compilation checking gets more difficult. > > > > It seems that I missed one change. I thought it was added in previous release > RTE_LIBRTE_BBDEV_DEBUG will be defined in config/common_base. > Are you ok with that?
These kind of compilation flags are not accepted in DPDK anymore, as they hide compilation issues. If you want to have a different path for debugging, you should use run-time flags, passed to the device configuration (I'd say through devargs). Thanks, Pablo