chrismattmann commented on a change in pull request #131: Changed the map and
reduce function to work with XmlRpcWorkflowManger
URL: https://github.com/apache/drat/pull/131#discussion_r193807542
##########
File path: proteus/src/main/java/backend/ProcessDratWrapper.java
##########
@@ -310,36 +391,65 @@ private boolean mapsStillRunning() throws Exception {
return items;
}
- @VisibleForTesting
- protected boolean stillRunning(List<WorkflowItem> items) {
- List<WorkflowItem> mapperItems = filterMappers(items);
- LOG.info("Checking mappers: inspecting ["
- + String.valueOf(mapperItems.size()) + "] mappers.");
- for (WorkflowItem mapperItem : mapperItems) {
- if (isRunning(mapperItem.getStatus())) {
- LOG.info("Mapper: [" + mapperItem.getId() + "] still running.");
- return true;
+ protected boolean stillRunning(List<WorkflowInstance> instances){
Review comment:
I think here you are reformatting white space. Don't do this. It makes it
hard to see if this is a real change or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
