chrismattmann commented on a change in pull request #131: Changed the map and reduce function to work with XmlRpcWorkflowManger URL: https://github.com/apache/drat/pull/131#discussion_r193806657
########## File path: proteus/src/main/java/backend/ProcessDratWrapper.java ########## @@ -72,7 +75,8 @@ private static final String RESET_CMD = "reset"; private static final String STATUS_IDLE = "idle"; - private static final String MAPPER_TASK = "urn:drat:RatCodeAudit"; +// private static final String MAPPER_TASK = "urn:drat:RatCodeAudit"; Review comment: I don't understand this. You use this exact string on L182 and yet you comment it out here so you can change the name of this static final String to something you can log. Why not simply just leave this KEY the way it is, and then just log the simple name (RatCodeAudit)? These keys are usually reused, and I think you have more chance to reuse the key the way it is than by creating a new key. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
